Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add mapping between membrane and ffmpeg profiles namings #107

Merged
merged 2 commits into from
Mar 14, 2024
Merged

Add mapping between membrane and ffmpeg profiles namings #107

merged 2 commits into from
Mar 14, 2024

Conversation

Noarkhh
Copy link
Contributor

@Noarkhh Noarkhh commented Feb 29, 2024 •
edited
Loading

varsill
varsill approved these changes Mar 6, 2024
View reviewed changes
Copy link
Contributor

@varsill varsill left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fair to me. I think for all these *_intra the profile_idc field contained in the H.264 SPS NALu is the same as for *:
image

@Noarkhh Noarkhh merged commit 19caea8 into master Mar 14, 2024
3 checks passed
@Noarkhh Noarkhh deleted the map-profiles branch March 14, 2024 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@varsill varsill varsill approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[H264] Encoder gets {:error, :codec_open} when trying to use profile :high_422
2 participants
@Noarkhh @varsill