Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dirty functions arity #108

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ Note: `Membrane.H264.FFmpeg.Parser` has been removed. Now you can use our pure E
Add the following line to your `deps` in `mix.exs`. Run `mix deps.get`.

```elixir
{:membrane_h264_ffmpeg_plugin, "~> 0.31.5"}
{:membrane_h264_ffmpeg_plugin, "~> 0.31.6"}
```

This package depends on the [ffmpeg](https://www.ffmpeg.org) libraries. The precompiled builds will be pulled and linked automatically. However, should there be any problems, consider installing it manually.
Expand Down
2 changes: 1 addition & 1 deletion c_src/membrane_h264_ffmpeg_plugin/decoder.spec.exs
Original file line number Diff line number Diff line change
Expand Up @@ -16,4 +16,4 @@ spec get_metadata(state) ::
{:ok :: label, width :: int, height :: int, pix_fmt :: atom}
| {:error :: label, :pix_fmt :: label}

dirty :cpu, decode: 3, flush: 1
dirty :cpu, decode: 5, flush: 2
2 changes: 1 addition & 1 deletion c_src/membrane_h264_ffmpeg_plugin/encoder.spec.exs
Original file line number Diff line number Diff line change
Expand Up @@ -27,4 +27,4 @@ spec flush(use_shm :: bool, state) ::
{:ok :: label, dts_list :: [int64], pts_list :: [int64], frames :: [payload]}
| {:error :: label, reason :: atom}

dirty :cpu, flush: 1, encode: 3
dirty :cpu, flush: 2, encode: 4
2 changes: 1 addition & 1 deletion mix.exs
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
defmodule Membrane.H264.FFmpeg.Plugin.MixProject do
use Mix.Project

@version "0.31.5"
@version "0.31.6"
@github_url "https://github.com/membraneframework/membrane_h264_ffmpeg_plugin"

def project do
Expand Down
39 changes: 20 additions & 19 deletions mix.lock

Large diffs are not rendered by default.

3 changes: 3 additions & 0 deletions test/decoder/decoding_test.exs
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,7 @@ defmodule DecoderTest do
pid = make_pipeline(in_path, out_path)
assert_end_of_stream(pid, :sink, :input, timeout)
assert_files_equal(out_path, ref_path)
Pipeline.terminate(pid)
end

defp perform_timestamping_test(filename, tmp_dir, frame_count) do
Expand All @@ -74,6 +75,8 @@ defmodule DecoderTest do
assert_sink_buffer(pid, :sink, %Membrane.Buffer{pts: pts})
assert expected_pts == pts
end)

Pipeline.terminate(pid)
end

describe "DecodingPipeline should" do
Expand Down
1 change: 1 addition & 0 deletions test/encoder/encoding_test.exs
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@ defmodule EncoderTest do

pid = make_pipeline(in_path, out_path, width, height, format)
assert_end_of_stream(pid, :sink, :input, 4000)
Pipeline.terminate(pid)
end

describe "EncodingPipeline should" do
Expand Down
1 change: 1 addition & 0 deletions test/transcoding/transcoding_test.exs
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ defmodule TranscodingTest do

pid = make_pipeline(in_path, out_path)
assert_end_of_stream(pid, :sink, :input, timeout)
Pipeline.terminate(pid)
end

describe "TranscodingPipeline should" do
Expand Down
Loading