Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle keyframe request it in the encoder and use x264 defaults #111

Merged
merged 10 commits into from
Jul 10, 2024
Merged

Handle keyframe request it in the encoder and use x264 defaults #111

merged 10 commits into from
Jul 10, 2024

Conversation

varsill
Copy link
Contributor

@varsill varsill commented Jul 4, 2024 •
edited
Loading

This PR:

  • adds handling of Membran.KeyframeRequestEvent
  • sets the default x264 parameters in the encoder instead of using FFmpeg default params
  • bump to v0.32.0

mat-hek
mat-hek requested changes Jul 8, 2024
View reviewed changes
lib/membrane_h264_ffmpeg/keyframe_request_event.ex Outdated
@@ -0,0 +1,5 @@
defmodule Membrane.H264.FFmpeg.KeyframeRequestEvent do
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's use https://hexdocs.pm/membrane_core/Membrane.KeyframeRequestEvent.html instead ;)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@varsill varsill requested a review from mat-hek July 9, 2024 13:21
@varsill varsill requested a review from mat-hek July 9, 2024 14:30
@varsill varsill changed the title Add keyframe request event and handle it in the encoder Handle keyframe request it in the encoder and use x264 defaults Jul 9, 2024
@varsill varsill merged commit c63cd5d into master Jul 10, 2024
3 checks passed
@varsill varsill deleted the force_keyframes branch July 10, 2024 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mat-hek mat-hek mat-hek approved these changes

@FelonEkonom FelonEkonom Awaiting requested review from FelonEkonom

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@varsill @mat-hek