Use a smaller retry delay on HTTP requests #208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wkozyra95
approved these changes
Nov 7, 2024
| {:ok, _} = Application.ensure_all_started(:req) | ||
|
|
||
| retry_delay_ms = fn retry_count -> retry_count * 100 end | ||
| req = Req.new(base_url: "http://#{@local_host_url}:#{lc_port}", retry_delay: retry_delay_ms) |
There was a problem hiding this comment.
If the concern is about the startup time, then I assume that /status requests are the main problem here. When we spawn an instance we try to send a status request and already have retry logic there, so I think a better approach here would be to disable retry entirely, but just on the /status endpoint.
But overall I don't see any problem with this approach (only the status endpoint is currently affected because POST requests are not retried), so I'm fine with leaving it as it is.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default Req uses a retry strategy of waiting 1000,2000,4000,8000ms between retries. This can really hurt pipeline startup latency if we are starting the LC on pipeline startup.