RTP Muxer #173
Open
RTP Muxer #173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Noarkhh
force-pushed
the
rtp-muxer
branch
5 times, most recently
from
178a7f5 to
3646889
Compare
Noarkhh
force-pushed
the
rtp-muxer
branch
3 times, most recently
from
ac6f353 to
5f98ea7
Compare
Noarkhh
force-pushed
the
rtp-muxer
branch
6 times, most recently
from
cb4e235 to
4b341c8
Compare
mat-hek
reviewed
Dec 19, 2024
lib/membrane/rtp/muxer.ex
Outdated
| @@ -0,0 +1,179 @@ | |||
| defmodule Membrane.RTP.Muxer do | |||
| @moduledoc false | |||
There was a problem hiding this comment.
Can we have a test where we demux and mux packets two times and check if we get the same results? That would need to happen on a stream that's already past the jitter buffer.
lib/membrane/rtp/muxer.ex
Outdated
| sequence_number = rem(stream_state.sequence_number + 1, @max_sequence_number + 1) | ||
|
|
||
| state = | ||
| Bunch.Struct.put_in(state, [:stream_states, pad_ref, :sequence_number], sequence_number) |
mat-hek
approved these changes
Dec 20, 2024
lib/membrane/rtp/muxer.ex
Outdated
| @@ -1,5 +1,9 @@ | |||
| defmodule Membrane.RTP.Muxer do | |||
| @moduledoc false | |||
| @moduledoc """ | |||
| Element that combines multiple streams into a single RTP stream. Each new input stream is assigned a unique SSRC, that the packets | |||
There was a problem hiding this comment.
The first line is used as a short description
Suggested change
| Element that combines multiple streams into a single RTP stream. Each new input stream is assigned a unique SSRC, that the packets | |
| Element that combines multiple streams into a single RTP stream. | |
| Each new input stream is assigned a unique SSRC, that the packets |
Comment on lines
116
to
119
| |> Bunch.Struct.update_in(:ssrc, &(&1 - ssrc)) | ||
| |> Bunch.Struct.update_in(:sequence_number, &(&1 - first_sequence_number)) | ||
| # round to ignore insignificant differences in timestamps | ||
| |> Bunch.Struct.update_in(:timestamp, &round((&1 - first_timestamp) / 10)) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes membraneframework/membrane_core#911