Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set default rtsp port #30

Merged
merged 1 commit into from
Jan 29, 2024
Merged

Set default rtsp port #30

merged 1 commit into from
Jan 29, 2024

Conversation

gBillal
Copy link
Contributor

@gBillal gBillal commented Jan 22, 2024

Set the rtsp url port to the default 554 in case it is not provided.

@darthez darthez requested a review from Noarkhh January 24, 2024 15:11
Noarkhh
Noarkhh approved these changes Jan 24, 2024
View reviewed changes
Copy link
Contributor

@Noarkhh Noarkhh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good to me :)

@Noarkhh Noarkhh self-assigned this Jan 25, 2024
@mat-hek mat-hek merged commit 37aed2a into membraneframework:master Jan 29, 2024
1 check failed
@gBillal gBillal deleted the rtsp-default-port branch January 29, 2024 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Noarkhh Noarkhh Noarkhh approved these changes

Assignees

@Noarkhh Noarkhh

Labels
None yet
Projects
Smackore
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gBillal @Noarkhh @mat-hek