Add a function to stop a RTSP server #43
Conversation
lib/membrane_rtsp/server.ex
Outdated
| Same as `GenServer.stop/2` | ||
| """ | ||
| @spec stop(pid(), reason :: term(), timeout()) :: :ok | ||
| def stop(server, reason \\ :normal, timeout \\ :infinity) do |
There was a problem hiding this comment.
I think we don't need the reason argument. I'd also accept a keyword to make it more future-proof
There was a problem hiding this comment.
I just copied the signature of GenServer.stop/2
There was a problem hiding this comment.
Yup, that's the point :P GenServer is generic and RTSP server is not. You don't have RTSPServer.call. I admit it's not a big deal though
There was a problem hiding this comment.
and the keyword would include fields like reason and timeout and also give us ability to add some options later, yes?
There was a problem hiding this comment.
I don't see a reason to put the reason there :P So it would be just timeout for now
and also give us ability to add some options later
yeah, without having many default arguments
No description provided.