Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix path bug #47

Merged
merged 2 commits into from
Oct 4, 2024
Merged

Fix path bug #47

merged 2 commits into from
Oct 4, 2024

Conversation

Noarkhh
Copy link
Contributor

@Noarkhh Noarkhh commented Oct 3, 2024 •
edited
Loading

When sending requests to an URI that, when parsed, has path field set to nil (e.g. rtsp://localhost:8554), there would be a crash in lib/membrane_rtsp/request.ex:173 by trying to call Path.relative_to/2 with first argument of nil.

This PR fixes this by setting the path to "/" if parsing of the provided URI resolves it to nil.

@Noarkhh Noarkhh requested a review from mat-hek October 3, 2024 12:36
@Noarkhh Noarkhh merged commit f89a915 into master Oct 4, 2024
4 checks passed
@Noarkhh Noarkhh deleted the fix-path-bug branch October 4, 2024 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mat-hek mat-hek mat-hek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Noarkhh @mat-hek