Membrane WebRTC plugin based on ex_webrtc #1
Conversation
| end | ||
|
|
||
| @impl true | ||
| def handle_child_notification(:connected, :webrtc, _ctx, state) do |
There was a problem hiding this comment.
Nitpick, a comment on why you don't handle :failed state might be useful
There was a problem hiding this comment.
Actually, we should handle the failed state :P I think we should raise in that case. Any idea how I can trigger the failed state in a test?
There was a problem hiding this comment.
When PC moves to the failed it exits with {:shutdown, reason} so you will be notified by your monitor
| @typedoc """ | ||
| Messages sent and received if `message_format` is `ex_webrtc`. | ||
| """ | ||
| @type ex_webrtc_message :: ExWebRTC.ICECandidate.t() | ExWebRTC.SessionDescription.t() |
There was a problem hiding this comment.
| @type ex_webrtc_message :: ExWebRTC.ICECandidate.t() | ExWebRTC.SessionDescription.t() | |
| @type ex_webrtc_message :: ICECandidate.t() | SessionDescription.t() |
| opts = Keyword.validate!(opts, message_format: :ex_webrtc, pid: self()) | ||
| opts = Map.new(opts) |> Map.put(:is_element, false) |
There was a problem hiding this comment.
you can have one big pipeline here
| end | ||
|
|
||
| @impl true | ||
| def handle_info({:signal, _from_pid, message}, %{peer_b: %{pid: nil}} = state) do |
There was a problem hiding this comment.
What if %{peer_b: nil} = state?
| queue | ||
| |> Enum.reverse() | ||
| |> Enum.each(&send_peer(state.peer_a, state.peer_b, &1)) | ||
|
|
||
| {:noreply, state} |
There was a problem hiding this comment.
Don't you want to reset the queue?
| @impl true | ||
| def handle_info(:ping, state) do | ||
| Process.send_after(self(), :ping, 30_000) | ||
| {:push, {:text, Jason.encode!(%{type: "ping", data: ""})}, state} | ||
| end |
lib/membrane_webrtc/source.ex
Outdated
| |> child(get_depayloader(kind, state)) | ||
| |> bin_output(pad_ref) | ||
| else | ||
| get_child(:webrtc) |> via_out(pad_ref) |> bin_output(pad_ref) |
There was a problem hiding this comment.
Why do you skip options: [kind: kind] in via_out?
| @@ -19,7 +20,17 @@ const start_connection = async (ws) => { | |||
| ws.send(JSON.stringify({ type: "ice_candidate", data: event.candidate })); | |||
| }; | |||
|
|
|||
| const localStream = await navigator.mediaDevices.getUserMedia(mediaConstraints); | |||
| pc.onconnectionstatechange = () => { | |||
There was a problem hiding this comment.
To be even more correct, we should check against pc.connectionState, like here
| PeerConnection.get_transceivers(pc) | ||
| |> Enum.filter(&(&1.direction == :sendrecv)) | ||
| |> Enum.each(&PeerConnection.set_transceiver_direction(pc, &1.id, :recvonly)) |
There was a problem hiding this comment.
Actually, this shouldn't be needed as by default, when a remote sdp offer is applied, a new transceiver is created with :recvonly direction
| @@ -109,8 +93,13 @@ defmodule Membrane.WebRTC.ExWebRTCSource do | |||
| {:connected, pad} -> | |||
| {[buffer: {pad, buffer}], state} | |||
|
|
|||
| {:queue, queue} -> | |||
| {[], %{state | output_tracks: %{output_tracks | id => {:queue, [buffer | queue]}}}} | |||
| {:awaiting, track} -> | |||
There was a problem hiding this comment.
Do you mean you're sure it never happens?
| @moduledoc """ | ||
| A simple WebSocket server spawned by `Membrane.WebRTC.Source` | ||
| and `Membrane.WebRTC.Sink`. It accepts a single connection | ||
| and passes the messages between the client and a Membrane | ||
| element. | ||
|
|
||
| The messages sent and received by the server are JSON-encoded | ||
| `t:Membrane.WebRTC.SignalingChannel.json_data_message/0`. | ||
| Additionally, the server sends a `{type: "keep_alive", data: ""}` | ||
| messages to prevent the WebSocket from being closed. | ||
|
|
||
| Examples of configuring and interacting with the server can | ||
| be found in the `examples` directory. | ||
| """ |
There was a problem hiding this comment.
Only docs and types are. I needed a place to put them, otherwise they'd have to be in both source and sink
Co-authored-by: Feliks Pobiedziński <[email protected]>
closes membraneframework/membrane_core#766