-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to GHC 8.6.5 #5
base: master
Are you sure you want to change the base?
Conversation
…ioed builds to not fail.
…ck builds to pass.
…ck builds to pass.
…pendency yaml requires generic deriving, which was introduced in 8.0). Also commented out stack 8.0.1 build - it fails too, but I'm not sure why, when the ghc 8.0.1 build passes.
The remaining builds always manage to fail - because at least one of them fails to download a compiler or library. Each build can pass, but at least one rolls a critical fail per run. I'm not entirely satisfied with this change. We gain 8.2.2, 8.4.4 and 8.6.5 support, but lose all support for 7.x. According to the 2018 State of Haskell survey (https://taylor.fausak.me/2018/11/18/2018-state-of-haskell-survey-results/#question-035) only 3% of respondents use anything earlier than 8.0. Is it worth cutting them off? You guys are much better Haskellers than I am - is there a way to make the library compatible for all? |
All but the nightly builds are now failing, it looks like due to a missing export from Aeson—-so I’m guessing it’s an incorrectly constrained cabal dependency. Otherwise the changes look pretty good, so it would be great to push this through. |
Previously, the most recent GHC I could compile this with was 8.0.2, which gives nasty linker warnings on OSX.
I'm not that confident of my ability to produce a properly constrained set of dependencies in cabal, though - it's probably worth checking if I broke something for earlier compilers.