Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add custom auth #308

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Add custom auth #308

wants to merge 1 commit into from

Conversation

antepusic
Copy link
Contributor

Description

This PR adds custom auth capabilities so that users can connect to GQLAlchemy with SSO tokens.

Pull request type

Please delete options that are not relevant.

  • Feature

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

######################################

Reviewer checklist (the reviewer checks this part)

  • Core feature implementation
  • Tests
  • Code documentation
  • Documentation on gqlalchemy/docs

######################################

@katarinasupe
Copy link
Contributor

katarinasupe commented Jun 24, 2024

@antepusic is there any test or example of how to use this feature in GQLAlchemy?
If you can, please add an example to https://memgraph.github.io/gqlalchemy/how-to-guides/overview/ as a separate guide -"Connect with SSO" or similar. I am mostly interested in how MG_SCHEME should look like.

FYI, as discussed, this will be included in the next release (July 10th). Work on Memgraph is a priority, so if you can't make it, we can move the milestone due date.

@antepusic
Copy link
Contributor Author

Thanks for the heads-up @katarinasupe! In the process of working on the docs, I’ll create a usage example and adapt it to GQLAlchemy tests & docs. This should happen sometime this week, does that work for you?

@katarinasupe
Copy link
Contributor

Hi @antepusic what is the status with this? Release should happen tomorrow, and we should have enough time to review.

@katarinasupe katarinasupe removed this from the v1.6.0 milestone Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Docs needed Docs needed feature feature status: draft PR is in draft phase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants