Allow custom XML parsers #157
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This small PR allows users to pull in their own XML parser, like for example https://github.com/leethomason/tinyxml2.
(1) It uses NanoSVG's existing XML parsing abstraction and just exposes it for users.
(2) Using a custom parser, it's quite easy to fully and elegantly support
<use>tags in SVGs, which would be very cumbersome in NanoSVG directly.(3) Many other features can be implemented through external XML rewriting in this custom parser, without having to touch NanoSVG, including some existing PRs (e.g. #123).
For a working example of (2), see
NanoSVGVisitorin https://github.com/poke1024/tove2d/blob/master/src/cpp/nsvg.cpp).