Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check for empty value #261

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Check for empty value #261

wants to merge 2 commits into from

Conversation

ReneLuecking
Copy link

see #260

@zonky2 zonky2 added the Feature label Sep 26, 2018
@zonky2 zonky2 added this to the 3.3.17 milestone Sep 26, 2018
@discordier
Copy link
Collaborator

What about values of 0?
Whenever a numerical 0 is used, this would output the default then. I don't think that this is really intended, is it?

@ReneLuecking
Copy link
Author

You're right. Maybe it would be better to check for an empty string or null instead of empty().

@discordier
Copy link
Collaborator

I guess this would be better then. 😺

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@davidmaack davidmaack

Labels
Feature
Projects
None yet
Milestone
3.3.17
Development

Successfully merging this pull request may close these issues.
5 participants
@ReneLuecking @discordier @davidmaack @zonky2 @sergroup