Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(js-sdk): Add array support for metadata fields in Node SDK #1020

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

RutamBhagat
Copy link
Contributor

Fixes: #857

This PR adds support for metadata fields to be returned as arrays in the Node SDK's type definitions, matching the backend's actual behavior. Some websites have multiple instances of the same metadata tag, which are correctly handled by the backend but weren't properly typed in the SDK.

Changes:

  • Updated FirecrawlDocumentMetadata interface to support string[] for relevant metadata fields
  • Maintained backward compatibility with existing string types
  • Added array support for commonly multi-valued meta tags (og:image, keywords, etc.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix the metadata types to have an optional array on the Node sdk
1 participant