Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove zstd support on tegra platform to allow building of mender-cli 3.5 #383

Open
wants to merge 1 commit into
base: dunfell
Choose a base branch
from

Conversation

PercevalSA
Copy link

zstd prevent the build of mender client 3.5.0 and upper on tegra platforms.

Copy link
Contributor

@TheYoctoJester TheYoctoJester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @PercevalSA, generally I'm fine with merging that as I understand it unblocks your build. However for our future selves, can you please extend the commit message such that it makes clear why exactly this is required (e.g., what in the toolchain, which dependency or which error causes the build breakage) and why this incorporates disabling the PTEST? Then I'm okay with going ahead. Thanks!

@TheYoctoJester
Copy link
Contributor

Hi @PercevalSA, generally I'm fine with merging that as I understand it unblocks your build. However for our future selves, can you please extend the commit message such that it makes clear why exactly this is required (e.g., what in the toolchain, which dependency or which error causes the build breakage) and why this incorporates disabling the PTEST? Then I'm okay with going ahead. Thanks!

@PercevalSA ping

@PercevalSA
Copy link
Author

Hello @TheYoctoJester ,

I only applied the changes I received from @MuchoLucho via support https://support.northern.tech/hc/en-us/requests/8848.
I have no idea on why removing PTEST is required.

The problem was when building mender-client from 3.5.0 version I received the following error messages

github.com/gorilla/websocket
# github.com/klauspost/compress/zstd/internal/xxhash
asm: illegal combination: 00072 (<unknown line number>)	PCALIGN	$16 ABCON0 NONE NONE NONE, 4 0
asm: illegal combination: 00072 (<unknown line number>)	PCALIGN	$16 ABCON0 NONE NONE NONE, 4 0
asm: illegal combination: 00072 (<unknown line number>)	PCALIGN	$16 ABCON0 NONE NONE NONE, 4 0
asm: illegal combination: 00072 (<unknown line number>)	PCALIGN	$16 ABCON0 NONE NONE NONE, 4 0
asm: illegal combination: 00032 (<unknown line number>)	PCALIGN	$16 ABCON0 NONE NONE NONE, 4 0
asm: illegal combination: 00032 (<unknown line number>)	PCALIGN	$16 ABCON0 NONE NONE NONE, 4 0
asm: illegal combination: 00032 (<unknown line number>)	PCALIGN	$16 ABCON0 NONE NONE NONE, 4 0
asm: illegal combination: 00032 (<unknown line number>)	PCALIGN	$16 ABCON0 NONE NONE NONE, 4 0
asm: assembly failed
github.com/minio/sha256-simd

[...]

# github.com/bmatsuo/lmdb-go/lmdb
mdb.c: In function 'mdb_cursor_put':
mdb.c:6535:9: warning: this statement may fall through [-Wimplicit-fallthrough=]
      if (SIZELEFT(fp) < offset) {
         ^
mdb.c:6540:5: note: here
     case MDB_CURRENT:
     ^~~~
github.com/mendersoftware/mender/store

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants