Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sigrid improvements #69

Merged
merged 6 commits into from
Dec 6, 2023
Merged

Sigrid improvements #69

merged 6 commits into from
Dec 6, 2023

Conversation

Robinfr
Copy link
Contributor

@Robinfr Robinfr commented Dec 6, 2023

Set up security scans for Sigrid and filter out irrelevant files.

Set up security scans for Sigrid and filter out irrelevant files.
Source option is required
@mendix mendix deleted a comment from github-actions bot Dec 6, 2023
Copy link

github-actions bot commented Dec 6, 2023

Sigrid maintainability feedback

✅ You wrote maintainable code and achieved your Sigrid objective of 3.0 stars

Sigrid compared your code against the baseline of 2023-11-20.

👍 What went well?

You fixed or improved 0 refactoring candidates.

👎 What could be better?

Unfortunately, 31 refactoring candidates were introduced or got worse.

Risk System property Location
🔴 Unit Size
(Introduced)
src/DeepLinkModule/javasource/deeplink/actions/ExecuteDeeplink.java
ExecuteDeeplink.executeAction()
🔴 Unit Size
(Introduced)
src/DeepLinkModule/javasource/deeplink/actions/ReadMicroflows.java
ReadMicroflows.executeAction()
🔴 Unit Interfacing
(Introduced)
src/DeepLinkModule/javasource/deeplink/actions/SetObjectParameterDeeplink.java
SetObjectParameterDeeplink.SetObjectParameterDeeplink(IContext,java.lang.String,java.lang.String,java.lang.String,java.lang.String,java.lang.String,java.lang.Boolean,java.lang.Boolean)
🔴 Unit Interfacing
(Introduced)
src/DeepLinkModule/javasource/deeplink/utils/DeeplinkUtils.java
DeeplinkUtils.updateOrCreateDeeplink(IContext,String,boolean,String,String,boolean,String,String)
🟠 Unit Size
(Introduced)
src/DeepLinkModule/javasource/deeplink/actions/ExecuteDeeplink.java
ExecuteDeeplink.processArgument(String,Map,Map)
🟠 Unit Size
(Introduced)
src/DeepLinkModule/javasource/deeplink/implementation/handler/ResponseHandler.java
ResponseHandler.serveLogin(IMxRuntimeRequest,IMxRuntimeResponse)
🟠 Unit Size
(Introduced)
src/DeepLinkModule/javasource/deeplink/implementation/handler/DeeplinkHandler.java
DeeplinkHandler.preparePendingLink(IContext,ISession,DeepLink,DeeplinkRequest)
🟠 Unit Size
(Introduced)
src/DeepLinkModule/javasource/deeplink/implementation/handler/DeeplinkHandler.java
DeeplinkHandler.processRequest(IMxRuntimeRequest,IMxRuntimeResponse,String)
🟠 Unit Size
(Introduced)
src/DeepLinkModule/javasource/deeplink/utils/DeeplinkUtils.java
DeeplinkUtils.updateOrCreateDeeplink(IContext,String,boolean,String,String,boolean,String,String)
🟠 Unit Complexity
(Introduced)
src/DeepLinkModule/javasource/deeplink/actions/ExecuteDeeplink.java
ExecuteDeeplink.executeAction()
🟠 Unit Complexity
(Introduced)
src/DeepLinkModule/javasource/deeplink/actions/ExecuteDeeplink.java
ExecuteDeeplink.processArgument(String,Map,Map)
🟠 Unit Complexity
(Introduced)
src/DeepLinkModule/javasource/deeplink/implementation/handler/ResponseHandler.java
ResponseHandler.serveLogin(IMxRuntimeRequest,IMxRuntimeResponse)
🟠 Unit Complexity
(Introduced)
src/DeepLinkModule/javasource/deeplink/implementation/handler/DeeplinkHandler.java
DeeplinkHandler.processRequest(IMxRuntimeRequest,IMxRuntimeResponse,String)
🟠 Unit Complexity
(Introduced)
src/DeepLinkModule/javasource/deeplink/actions/ReadMicroflows.java
ReadMicroflows.executeAction()
🟠 Unit Interfacing
(Introduced)
src/DeepLinkModule/javasource/deeplink/actions/SetStringParameterDeeplink.java
SetStringParameterDeeplink.SetStringParameterDeeplink(IContext,java.lang.String,java.lang.String,java.lang.String,java.lang.Boolean,java.lang.Boolean)
🟡 Unit Size
(Introduced)
src/DeepLinkModule/javasource/deeplink/implementation/handler/ResponseHandler.java
ResponseHandler.serveSSOHandler(IMxRuntimeRequest,IMxRuntimeResponse)
🟡 Unit Size
(Introduced)
src/DeepLinkModule/javasource/deeplink/implementation/handler/ResponseHandler.java
ResponseHandler.serveIndex(IMxRuntimeRequest,IMxRuntimeResponse,String)
🟡 Unit Size
(Introduced)
src/DeepLinkModule/javasource/deeplink/implementation/handler/helpers/DeeplinkRequest.java
DeeplinkRequest.DeeplinkRequest(IMxRuntimeRequest)
🟡 Unit Size
(Introduced)
src/DeepLinkModule/javasource/deeplink/implementation/handler/DeeplinkHandler.java
DeeplinkHandler.getDeepLinkConfigurationObject(IContext,String)
🟡 Unit Complexity
(Introduced)
src/DeepLinkModule/javasource/deeplink/implementation/handler/ResponseHandler.java
ResponseHandler.serveSSOHandler(IMxRuntimeRequest,IMxRuntimeResponse)
🟡 Unit Complexity
(Introduced)
src/DeepLinkModule/javasource/deeplink/implementation/handler/ResponseHandler.java
ResponseHandler.serveIndex(IMxRuntimeRequest,IMxRuntimeResponse,String)
🟡 Unit Complexity
(Introduced)
src/DeepLinkModule/javasource/deeplink/implementation/handler/helpers/DeeplinkRequest.java
DeeplinkRequest.DeeplinkRequest(IMxRuntimeRequest)
🟡 Unit Complexity
(Introduced)
src/DeepLinkModule/javasource/deeplink/implementation/handler/DeeplinkHandler.java
DeeplinkHandler.preparePendingLink(IContext,ISession,DeepLink,DeeplinkRequest)
🟡 Unit Complexity
(Introduced)
src/DeepLinkModule/javasource/deeplink/utils/DeeplinkUtils.java
DeeplinkUtils.updateOrCreateDeeplink(IContext,String,boolean,String,String,boolean,String,String)
🟡 Unit Interfacing
(Introduced)
src/DeepLinkModule/javasource/deeplink/actions/ExecuteDeeplink.java
ExecuteDeeplink.processArgument(String,Map,Map)
🟡 Unit Interfacing
(Introduced)
src/DeepLinkModule/javasource/deeplink/implementation/handler/ResponseHandler.java
ResponseHandler.serveIndex(IMxRuntimeRequest,IMxRuntimeResponse,String)
🟡 Unit Interfacing
(Introduced)
src/DeepLinkModule/javasource/deeplink/implementation/handler/DeeplinkExecutionHandler.java
DeeplinkExecutionHandler.execute(IContext,String,HashMap)
🟡 Unit Interfacing
(Introduced)
src/DeepLinkModule/javasource/deeplink/implementation/handler/DeeplinkHandler.java
DeeplinkHandler.preparePendingLink(IContext,ISession,DeepLink,DeeplinkRequest)
🟡 Unit Interfacing
(Introduced)
src/DeepLinkModule/javasource/deeplink/implementation/handler/DeeplinkHandler.java
DeeplinkHandler.getObjectByRequestParameters(IContext,DeepLink,DeeplinkRequest)
🟡 Unit Interfacing
(Introduced)
src/DeepLinkModule/javasource/deeplink/implementation/handler/DeeplinkHandler.java
DeeplinkHandler.processRequest(IMxRuntimeRequest,IMxRuntimeResponse,String)
🟡 Unit Interfacing
(Introduced)
src/DeepLinkModule/javasource/deeplink/actions/GetAttributeValueByEntityName.java
GetAttributeValueByEntityName.GetAttributeValueByEntityName(IContext,java.lang.String,java.lang.String)

📚 Remaining technical debt

0 refactoring candidates didn't get better or worse, but are still present in the code you touched.

Sigrid ratings

System property Baseline on 2023-11-20 New/changed code
Volume (4.3) N/A
Duplication (2.2) 5.5
Unit Size (3.5) 2.1
Unit Complexity (3.6) 1.6
Unit Interfacing (5.0) 1.5
Module Coupling (4.0) 5.5
Component Independence (N/A) N/A
Component Entanglement (N/A) N/A
Maintainability (3.6) 3.4

The module does not meet the target quality of 3.5 at this moment
@Robinfr Robinfr merged commit f6b84f2 into master Dec 6, 2023
6 checks passed
@Robinfr Robinfr deleted the sigrid-improvements branch December 6, 2023 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant