Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run MxBuild outside CF Buildpack #201

Merged
merged 8 commits into from
Sep 2, 2024
Merged

Run MxBuild outside CF Buildpack #201

merged 8 commits into from
Sep 2, 2024

Conversation

zlogic
Copy link
Member

@zlogic zlogic commented Aug 26, 2024

  • Provided a build.py script that accepts most inputs (MDA or MPK file, or a project source dir) and produces an extracted MDA directory.
  • Upgraded to ubi9 as the base OS.

This removes support for building MPR projects using CF Buildpack, and instead builds MPR files outside CF Buildpack.

Use prebuilt image builder with all Java versions.
Download MxBuild inside container (improves layer reuse).
This helps if Docker/Podman runs as a different user.

Other changes:
* Detect Git commit
* Fixed log levels (stdout/stderr can be used for different purposes)
* Stop container on termination
* Allow to use a prebuilt repository cache
* Migrated to ubi9 where possible
* Provide DataDog helper scripts (to test later)
* Use stdout_open instead of duplicating stderr_open
* Support Docker output format
* Improve metadata detection handling
* Run build as root (Docker seems to ignore USER when copying files)
* Updated integration test
@zlogic zlogic changed the base branch from master to latest August 26, 2024 23:06
@zlogic zlogic marked this pull request as ready for review August 26, 2024 23:06
Copy link
Collaborator

@GiriChandana123 GiriChandana123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed, looks good.
@zlogic I think I do not have write access to the repository, to merge the changes into latest.

@zlogic zlogic merged commit 07f286a into latest Sep 2, 2024
1 check passed
@zlogic zlogic deleted the mxbuild-externally branch September 2, 2024 12:39
@GiriChandana123
Copy link
Collaborator

GiriChandana123 commented Sep 5, 2024

@zlogic [tests/Integrationtest.sh]
The issue"copytree() got an unexpected keyword argument 'dirs_exist_ok' " is solved by installing the python version 3.8 or later. Reference https://stackoverflow.com/questions/63661976/problems-using-shutil-copytree-in-python. So I think it would make sense to add in the requirements of the ReadME file as well, to use python 3.8 or later version

@zlogic
Copy link
Member Author

zlogic commented Sep 9, 2024

Thank you @GiriChandana123, I've added a PR, could you please take a look? #203

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants