Allow MaxLength magic number assignment for MEN010

Also, allow FromMicroseconds and FromMinutes TimeSpan methods
menees · Mar 27, 2024 · 8c168ea · 8c168ea
1 parent a401dd6
commit 8c168ea
Show file tree

Hide file tree

Showing 5 changed files with 12 additions and 2 deletions.
diff --git a/src/Directory.Build.props b/src/Directory.Build.props
@@ -22,7 +22,7 @@
 
 		<!-- Make the assembly, file, and NuGet package versions the same. -->
 		<!-- NOTE: Change the version in Vsix\source.extension.vsixmanifest to match this! -->
-		<Version>3.0.12</Version>
+		<Version>3.0.13</Version>
 	</PropertyGroup>
 
 	<PropertyGroup Condition="'$(Configuration)'=='Debug'">

diff --git a/src/Menees.Analyzers/Men010AvoidMagicNumbers.cs b/src/Menees.Analyzers/Men010AvoidMagicNumbers.cs
@@ -111,6 +111,12 @@ private static bool InAllowedDeclarationContext(LiteralExpressionSyntax literalE
 							case SyntaxKind.RangeExpression:
 								allowed = literalExpression.Parent == ancestor;
 								break;
+
+							case SyntaxKind.SimpleAssignmentExpression:
+								allowed = ancestor is AssignmentExpressionSyntax assignment
+									&& assignment.Left is MemberAccessExpressionSyntax member
+									&& settings.IsAllowedNumericLiteralCaller(member.Name.Identifier.Text);
+								break;
 						}
 
 						return allowed;

diff --git a/src/Menees.Analyzers/Settings.cs b/src/Menees.Analyzers/Settings.cs
@@ -76,7 +76,7 @@ internal sealed class Settings
 		private readonly HashSet<string> allowedNumericLiterals = new(new[] { "0", "1", "2", "100" });
 		private readonly HashSet<string> allowedNumericCallerNames = new(new[]
 		{
-			"FromDays", "FromHours", "FromMilliseconds", "FromSeconds", "FromTicks"
+			"FromDays", "FromHours", "FromMicroseconds", "FromMilliseconds", "FromMinutes", "FromSeconds", "FromTicks", "MaxLength"
 		});
 		private readonly IEnumerable<Predicate<string>>? allowedNumericCallerRegexes;
 		private readonly Dictionary<string, string> preferredTerms = DefaultPreferredTerms;

diff --git a/tests/Menees.Analyzers.Test/Men010UnitTests.cs b/tests/Menees.Analyzers.Test/Men010UnitTests.cs
@@ -73,6 +73,9 @@ public double GetRate()
 				return FridayValue;
 		}
 
+		DataColumn col = new(""Test"", typeof(string));
+		col.MaxLength = 20;
+
 		const int DefaultValue = 17;
 		return DefaultValue;
 	}

diff --git a/tests/Menees.Analyzers.Test/Menees.Analyzers.Settings.xml b/tests/Menees.Analyzers.Test/Menees.Analyzers.Settings.xml
@@ -30,6 +30,7 @@
 		<Literal>1</Literal>
 		<Literal>2</Literal>
 		<CallerName>FromDays</CallerName>
+		<CallerName>MaxLength</CallerName>
 		<CallerRegex>^From(Hours|Minutes)$</CallerRegex>
 	</AllowedNumericLiterals>