Skip to content

Commit

Permalink
v2.0.2
Browse files Browse the repository at this point in the history
  • Loading branch information
meokullu committed Sep 2, 2023
1 parent 23cd0cb commit 3fdd087
Show file tree
Hide file tree
Showing 4 changed files with 13 additions and 10 deletions.
11 changes: 7 additions & 4 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,12 @@ Returns line list of content that are trimöed.

## Version History

* 2.0.2
* Fixed naming violations.

* 2.0.1
* Fixed naming violations.

* 2.0.0
* Fixing naming vialations inside of SubtitleBlock. Public members names start with uppercase now.

Expand All @@ -59,13 +65,10 @@ Returns line list of content that are trimöed.
* 1.0.0 Initial Release

## Task List
- [x] Safe versions of methods
- [x] Offer TrimmedLineIndexList as public
- [x] Some order numbers are not integers. E.g 1.1 1.2
- [ ] Support multiple culture for notations on time marks.

## Licence
No license is required.
[MIT license](https://github.com/meokullu/SubtitleParser/blob/master/LICENSE)

## Authors
Twitter: Enes Okullu [@enesokullu](https://twitter.com/EnesOkullu)
Expand Down
Binary file modified SubtitleParser/OutputDLL/SubtitleParser.dll
Binary file not shown.
6 changes: 3 additions & 3 deletions SubtitleParser/SubtitleParser.cs
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,7 @@ public static List<SubtitleBlock> ParseSubtitleList(string[] subtitleLines)
List<string> GetInlineText()
{
// Variable holds lines of contents.
List<string> _innerTextList = new List<string>();
List<string> innerTextList = new List<string>();

// Loop while next line is not null and file content is not finished
while ((i + 2 < subtitleLines.Length) && string.IsNullOrEmpty(subtitleLines[i + 2]) == false)
Expand All @@ -159,14 +159,14 @@ List<string> GetInlineText()
#endregion Trimming

// Adding line into internal variable.
_innerTextList.Add(subtitleLines[i + 2]);
innerTextList.Add(subtitleLines[i + 2]);

// Increasing variable to check if next line is null, empty or filled line.
i++;
}

// Returning list of text contents.
return _innerTextList;
return innerTextList;
}
}
catch (Exception ex)
Expand Down
6 changes: 3 additions & 3 deletions SubtitleParser/SubtitleParser.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,8 @@
<TargetFramework>net7.0</TargetFramework>
<ImplicitUsings>enable</ImplicitUsings>
<Nullable>enable</Nullable>
<AssemblyVersion>2.0.1</AssemblyVersion>
<FileVersion>2.0.1</FileVersion>
<AssemblyVersion>2.0.2</AssemblyVersion>
<FileVersion>2.0.2</FileVersion>
<GeneratePackageOnBuild>True</GeneratePackageOnBuild>
<PackageLicenseFile>LICENSE.txt</PackageLicenseFile>
<Title>Subtitle Parser</Title>
Expand All @@ -22,7 +22,7 @@
Fixing variable name inside of SubtitleBlock. Public members start with uppercase now.
Icon error was fixed.
</PackageReleaseNotes>
<Version>2.0.1</Version>
<Version>2.0.2</Version>
<ApplicationIcon>Resources\icon.ico</ApplicationIcon>
<PackageIcon>Resources\icon.png</PackageIcon>
</PropertyGroup>
Expand Down

0 comments on commit 3fdd087

Please sign in to comment.