Add Flag for 8.1.0.0 release #294
Conversation
| @@ -4,6 +4,7 @@ const { loadRules } = require("./rulesUtils"); | |||
| let info = console.info; | |||
| beforeEach(() => { | |||
| console.info = () => {}; | |||
| process.env.CURAM_VERSION="8.3"; | |||
There was a problem hiding this comment.
Great nice that we can test this
| @@ -5,7 +5,11 @@ const filesAndFolders = require("./filesAndFolders"); | |||
| */ | |||
| const loadRules = config => { | |||
| const rulesJson = []; | |||
| const rulesFiles = filesAndFolders.glob(`${config.cssRulesTool.rulesFolder}/*.json`); | |||
| if(process.env.CURAM_VERSION == "8.1.0.0"){ | |||
There was a problem hiding this comment.
This will work fine for this release but is not ideal from a maintenance perspective! For example for 8.3.0 or 8.2.1.0, we have to make this an allowlist with valid versions and we would have to update the list for each release!
There are actually 2 ways to handle this! The first is an allowlist like described above and have to maintain that list. A better way is to examine the second digit of CURAM_VERSION. So for 8.1.0, the 2nd digit is 1, for 8.2.0, it is 2 e.t.c. Just check that 2nd digit is greater than 0. For V9 this logic may have to change but you could validate that first digit is 8.
By the way it might also be worth doing a validation check using a regular expression to ensure that the CURAM_VERSION is in the pattern 8.{0-9}.{0-9}.{0-9}. You can use a regular expression service to some up with pattern : https://www.regextester.com/. SHould be quite easy actually:-)
| @@ -5,7 +5,15 @@ const filesAndFolders = require("./filesAndFolders"); | |||
| */ | |||
| const loadRules = config => { | |||
| const rulesJson = []; | |||
| const rulesFiles = filesAndFolders.glob(`${config.cssRulesTool.rulesFolder}/*.json`); | |||
| const curamVersion = process.env.CURAM_VERSION; | |||
| const regex = new RegExp("[8].[1-9].[0-9].[0-9]"); | |||
There was a problem hiding this comment.
I wonder will this Regex satisfy an IFix too? e.g 8.1.0.0_iFix1. As it is it might satisfy an iFix condition too or you might have to add a "." e.g new RegExp("[8].[1-9].[0-9].[0-9]."
No description provided.