Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Install.md #3000

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

TechProofreader
Copy link
Contributor

@TechProofreader TechProofreader commented Jun 21, 2024

Corrected grammatical and spelling mistakes, created some lists, added hyperlinks, added explanatory notes, corrected some instructions, and reorganized parts of the page.

As a side note, in the past, I have done some technology compliance work for a relative who runs a healthcare nonprofit in France, and I just wanted to note that Mercedes may want to switch the JSON Web Token generator linked website to something else. The reason being is that the currently linked website is hosted on an Amazon server in the United States, and using a token generated from that website may violate EU GDPR regulations since the generated token may be considered data generated outside of the EU, which could violate some provisions if used by people or organizations within the EU. That website does not appear to have any Data Protection Officer (DPO) listed on any of their pages, so there is no way of verifying if they are in compliance with GDPR provisions.

Please let me know if you have any questions.

Take Care

Corrected grammatical and spelling mistakes as well as creating lists, adding hyperlinks, explanatory notes, correcting some instructions, and reorganizing parts of the page.

As a side note, in the past, I have done some technology compliance work for a relative who runs a healthcare nonprofit in France, and I just wanted to note that Mercedes may want to switch the JSON Web Token generator linked website to something else. The reason being is that the currently linked website is hosted on an Amazon server in the United States, and using a token generated from that website may violate EU GDPR regulations since the generated token may be considered data generated outside of the EU, which could violate some provisions if used by people or organizations within the EU. That website does not appear to have any Data Protection Officer (DPO) listed on any of their pages, so there is no way of verifying if they are in compliance with GDPR provisions.

Please let me know if you have any questions.

Take Care
@kameshbrao
Copy link
Collaborator

@TechProofreader thanks for reviewing this and pointing out the issue with JWT generator. However, curious to know the JSON Web Token Generator website that you are mentioning. Can you provide more details on this?

@TechProofreader
Copy link
Contributor Author

@TechProofreader thanks for reviewing this and pointing out the issue with JWT generator. However, curious to know the JSON Web Token Generator website that you are mentioning. Can you provide more details on this?

Hi @kameshbrao,

This is the link that is currently linked on the install page:

https://www.javainuse.com/jwtgenerator

I’m thinking it would be better to simply instruct the user to utilize a JSON Web Token generator, rather than linking a website. This way, MB is not responsible for any issues that may arise from a third party website.

Let me know what you think. If you agree, then I’ll update my PR to add in that revision.

Take Care

@kameshbrao
Copy link
Collaborator

@TechProofreader agree on that. Please raise the PR.

@kameshrao

I have revised my PR to remove the JWT link and instead instruct the user to find a JWT generator on their own. I made a few more final edits in language choice as well.

Please let me know if you have any further questions or concerns.

Take Care
@TechProofreader
Copy link
Contributor Author

@TechProofreader agree on that. Please raise the PR.

Hi @kameshbrao,

I have revised my PR to remove the JWT generator link and instead added language that instructs the user to find a generator on their own. I also made some final edits here and there regarding language choice.

Please let me know if you have any further questions or concerns.

Take Care

Side note: In this latest commit description, I meant to tag you, but my computer's autocorrect changed your username at the last minute, so please disregard that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants