Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
The web-configurator fetches config options from the local storage and then filters out any object keys that aren't config option keys and stores the filtered data in the
result
variable. It then returns theinitial
object instead of theresult
, which doesn't make sense.The webpack config files of the ts-config-webpack-plugin miss escaping the second dot of definition files.
Issue Number: N/A
What is the new behavior?
With this Commit, the
result
gets returned instead of theinitial
.With this [Commit[(https://github.com/merkle-open/webpack-config-plugins/commit/43c6ecd153753e9692db3945fddd18d2175cec62), the missing escaping of the second dot gets introduced.
Does this PR introduce a breaking change?
Other information