Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/functional mistakes #100

Merged
merged 3 commits into from
Sep 10, 2021
Merged

Bugfix/functional mistakes #100

merged 3 commits into from
Sep 10, 2021

Conversation

oliverdietsche
Copy link
Contributor

@oliverdietsche oliverdietsche commented Sep 2, 2021

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines: link tbd.
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] tooling / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

  1. The web-configurator fetches config options from the local storage and then filters out any object keys that aren't config option keys and stores the filtered data in the result variable. It then returns the initial object instead of the result, which doesn't make sense.

  2. The webpack config files of the ts-config-webpack-plugin miss escaping the second dot of definition files.

Issue Number: N/A

What is the new behavior?

  1. With this Commit, the result gets returned instead of the initial.

  2. With this [Commit[(https://github.com/merkle-open/webpack-config-plugins/commit/43c6ecd153753e9692db3945fddd18d2175cec62), the missing escaping of the second dot gets introduced.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@ernscht
Copy link
Member

ernscht commented Sep 10, 2021

Regardless of whether it makes sense to use d.ts file in webpack (#18 & #81), these two fixes make sense.
Many thanks for this. And a special thanks for the tests.

@ernscht ernscht merged commit dca5e53 into master Sep 10, 2021
@ernscht ernscht deleted the bugfix/functional-mistakes branch September 10, 2021 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants