Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed docker ports for local development #1256

Merged
merged 1 commit into from
Jul 7, 2023

Conversation

nirname
Copy link
Contributor

@nirname nirname commented Jun 20, 2023

📑 Summary

Description in the README did not match ports in docker compose

📏 Design Decisions

Describe the way your implementation works or what design decisions you made if applicable:

📋 Tasks

Make sure you

  • 📖 have read the contribution guidelines
  • 💻 have added unit/e2e tests (if appropriate)
  • 🔖 targeted develop branch

@netlify
Copy link

netlify bot commented Jun 20, 2023

Deploy Preview for mermaidjs ready!

Name Link
🔨 Latest commit ea0669a
🔍 Latest deploy log https://app.netlify.com/sites/mermaidjs/deploys/6490fa114c745b0008278a0d
😎 Deploy Preview https://deploy-preview-1256--mermaidjs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@nirname nirname requested a review from sidharthv96 July 3, 2023 17:07
@sidharthv96 sidharthv96 added this pull request to the merge queue Jul 7, 2023
Merged via the queue into mermaid-js:develop with commit 1a7cbab Jul 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants