Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add collections migrations between instances #40

Open
wants to merge 20 commits into
base: master
Choose a base branch
from

Conversation

davert0
Copy link

@davert0 davert0 commented Sep 27, 2022

Hi, I have added full collection migration between different metabase instances including dashboards visualization, any comments would be appreciated

@davert0 davert0 changed the title Add migrations between instances Add collections migrations between instances Sep 27, 2022
@mertsalik mertsalik self-requested a review October 21, 2022 12:08
@mertsalik
Copy link
Owner

Will do a detailed review asap. Thanks.

Copy link
Owner

@mertsalik mertsalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have walked through this PR. Thanks for the effort.
Could you please remove the specific file names from the gitignore ( i couldn't understand the purpose ), and skip the deletion of get_by_collection method which is used by some command scripts ( someone might be using those scripts, that change will broke them ).

Thanks.

@@ -95,3 +95,6 @@ gen
# virtual environment
venv/
.venv/

collab.json
password.txt
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we really need those two specific files to be ignored ?

)
Resource.validate_response(response=resp)
return resp.json()

def get_by_collection(self, collection_slug):
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is used by the helper scripts:

  • exporter.py
  • migrator.py
    although they are a bit old, i suggest to keep this method.

@@ -304,23 +421,36 @@ def get(self, collection_id=None, archived=False):
url=url,
headers=self.prepare_headers(),
verify=self.verify,
proxies=self.proxies
proxies=self.proxies,
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for overall styling & format. ✌️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants