Skip to content

Commit

Permalink
docs: add deprecation to .nullifzero docstring
Browse files Browse the repository at this point in the history
Although users got a deprecationWarning
whenever they used these in code,
in the docs there is no
indication they are deprecated.
  • Loading branch information
NickCrews authored and cpcloud committed Oct 8, 2023
1 parent 734bd91 commit 8502e81
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions ibis/expr/types/numeric.py
Original file line number Diff line number Diff line change
Expand Up @@ -8,10 +8,10 @@

import ibis
import ibis.expr.operations as ops
from ibis import util
from ibis.common.exceptions import IbisTypeError
from ibis.expr.types.core import _binop
from ibis.expr.types.generic import Column, Scalar, Value
from ibis import util

if TYPE_CHECKING:
import ibis.expr.types as ir
Expand Down Expand Up @@ -483,12 +483,12 @@ def sqrt(self) -> NumericValue:

@util.deprecated(instead="use nullif(0)", as_of="7.0", removed_in="8.0")
def nullifzero(self) -> NumericValue:
"""Return `NULL` if an expression is zero."""
"""DEPRECATED: Use `nullif(0)` instead."""
return self.nullif(0)

@util.deprecated(instead="use fillna(0)", as_of="7.0", removed_in="8.0")
def zeroifnull(self) -> NumericValue:
"""Return zero if an expression is `NULL`."""
"""DEPRECATED: Use `fillna(0)` instead."""
return self.fillna(0)

def acos(self) -> NumericValue:
Expand Down

0 comments on commit 8502e81

Please sign in to comment.