-
Notifications
You must be signed in to change notification settings - Fork 605
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI Fix: Modal Category Type Now Visible in Light/Dark Modes #2015
base: master
Are you sure you want to change the base?
UI Fix: Modal Category Type Now Visible in Light/Dark Modes #2015
Conversation
Signed-off-by: Tharanishwaran <[email protected]>
Yay, your first pull request! 👍 A contributor will be by to give feedback soon. In the meantime, please review the Newcomers' Guide and sure to join the community Slack. |
✅ Deploy Preview for mesheryio-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Signed-off-by: Tharanishwaran <[email protected]>
Hi @vishalvivekm @sudhanshutech could you please review this PR and let me know if any changes are needed. |
looks good |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Tharanishwaran
There should be no effect on hover; it just needs to stay as a chip.
Also, I understand that the following may not be within the scope of the corresponding issue, but could you please take a look at fixing these two points:
Thank you for the feedback @Touriist. I will address the hover effect and modal fixes promptly. |
Signed-off-by: Tharanishwaran <[email protected]>
@Touriist However, regarding the first issue about modal height - I'm unable to reproduce or see any height-related problems in the current version. Could you please provide more details. |
Description
This PR fixes #2010
Notes for Reviewers
Screenshot
Signed commits