-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixed the ci golint file exists #380
Conversation
Signed-off-by: captain-Akshay <[email protected]>
Yay, your first pull request! 👍 A contributor will be by to give feedback soon. In the meantime, please review the Layer5 Community Welcome Guide and sure to join the community Slack. |
@theBeginner86 do let me know your review or feedback! |
Running build checks... |
Can you run |
@nebula-aac got this error :- & when i commented the unused variable the code |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nebula-aac got this error :-
& when i commented the unused variable the code
golangci-lint run ./... --fix
run fine!
Sounds good to me. Lets remove the un-used occurrences of var.
@theBeginner86 actually i checked the whole function and the komposeObject is being used in this file
to
now i might be wrong because I'm newbie in go 😅 but if you have something else do let me know ! this gives out no error while running |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
This issue is being automatically closed due to inactivity. However, you may choose to reopen this issue. |
Description
This PR fixes #378
reference to github issue where the golangci-lint crew recommends this workaround: golangci/golangci-lint-action#244
Notes for Reviewers
This will increase the time complexity.
skip-pkg-cache: true
skip-build-cache: true
Signed commits