Update ci configuration and fixed the code error and security issue #389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yay, your first pull request! 👍 A contributor will be by to give feedback soon. In the meantime, please review the Layer5 Community Welcome Guide and sure to join the community Slack. |
Aisuko
changed the title
Signed-off-by: GitHub <[email protected]>
leecalcote
added
security
dependencies
leecalcote
reviewed
Oct 16, 2023
| if err != nil { | ||
| return err | ||
| } | ||
| return walkSummarizeExport(globalFlags, true, updateAll) | ||
| return walkSummarizeExport(gFlags, true, updateAll) |
leecalcote
reviewed
Oct 16, 2023
| github.com/kubernetes/kompose v1.26.1 | ||
| github.com/layer5io/meshery-operator v0.6.10 | ||
| github.com/layer5io/meshery-operator v0.6.13 |
| @@ -19,7 +19,7 @@ func GenerateComponents(ctx context.Context, manifest string, resource int, cfg | |||
| crds = cfg.ExtractCrds(manifest) | |||
| for _, crd := range crds { | |||
| var parsedCrd cue.Value | |||
| if cfg.CrdFilter.IsJson != true { | |||
| if !cfg.CrdFilter.IsJson { | |||
| @@ -156,70 +122,6 @@ func RemoveHelmTemplatingFromCRD(crdyaml *string) { | |||
| *crdyaml = strings.Join(yamlArr, "\n---\n") | |||
| } | |||
|
|
|||
| func getCrdnames(s string) []string { | |||
There was a problem hiding this comment.
@MUzairS15, will you confirm that Meshery Server/other doesn't use this function or the filterYaml() function any longer?
There was a problem hiding this comment.
@KiptoonKipkurui you might be able to offer similar confirmation
There was a problem hiding this comment.
Confirmed: No use inside of Meshery Server.
|
Thanks for your contribution to Meshery! 🎉 
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes #386
Notes for Reviewers
This PR fixed:
https://github.com/meshery/meshkit/security/dependabot/57
https://github.com/meshery/meshkit/security/dependabot/58
https://github.com/meshery/meshkit/security/dependabot/59
https://github.com/meshery/meshkit/security/dependabot/63
Signed commits