Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update helm dependancy #421

Merged
merged 1 commit into from
Dec 3, 2023
Merged

fix: update helm dependancy #421

merged 1 commit into from
Dec 3, 2023

Conversation

VihasMakwana
Copy link
Member

@VihasMakwana VihasMakwana commented Nov 30, 2023 •
edited
Loading

There was a bogus debug statement in helm package which caused flaky behavior in mesheryctl.
It was addressed via helm/helm#12454 and helm/helm#12445.
Update helm to 3.13.2 to resolve this.

Description

This PR fixes #

Notes for Reviewers

Signed commits

  • Yes, I signed my commits.

@VihasMakwana
fix: update helm dependancy
65e8317 
There was a bogus debug statement in helm package which caused flaky behaviour in mesheryctl.
It was addressed via helm/helm#12454 helm/helm#12445.
Update helm package to 3.13.2 to resolve this.

Signed-off-by: Vihas Makwana <[email protected]>
@welcome Welcome
Copy link

welcome bot commented Nov 30, 2023

Yay, your first pull request! 👍 A contributor will be by to give feedback soon. In the meantime, please review the Layer5 Community Welcome Guide and sure to join the community Slack.
Be sure to double-check that you have signed your commits. Here are instructions for making signing an implicit activity while peforming a commit.

@VihasMakwana
Copy link
Member Author

Current behavior:
Screenshot_20231130_125105

Notice the

Deploying Meshery on Kubernetesfalse
Deploying Meshery on Kubernetes

It shouldn't happen. Upgrading helm resolves this as the latest patch release has a fix for this.

@leecalcote leecalcote requested a review from MUzairS15 December 1, 2023 02:54
@leecalcote leecalcote added dependencies Pull requests that update a dependency file framework/helm labels Dec 1, 2023
MUzairS15
MUzairS15 reviewed Dec 1, 2023
View reviewed changes
Copy link

@MUzairS15 MUzairS15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thankyou @VihasMakwana.

Will you look at the failing lint checks?

@VihasMakwana
Copy link
Member Author

VihasMakwana commented Dec 1, 2023 •
edited
Loading

@MUzairS15 It seems to be unrelated to my PR.
I'll raise a FIX PR though.

@leecalcote leecalcote mentioned this pull request Dec 3, 2023
Closed
leecalcote
leecalcote approved these changes Dec 3, 2023
View reviewed changes
Copy link
Member

@leecalcote leecalcote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

A separate issue has been raised (#425), @VihasMakwana

@leecalcote leecalcote merged commit e15f4a2 into meshery:master Dec 3, 2023
5 of 6 checks passed
@welcome Welcome
Copy link

welcome bot commented Dec 3, 2023

Thanks for your contribution to Meshery! 🎉

Shows a black logo in light color mode and a white one in dark color mode.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MUzairS15 MUzairS15 MUzairS15 left review comments

@leecalcote leecalcote leecalcote approved these changes

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file framework/helm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@VihasMakwana @leecalcote @MUzairS15