feat: annotations property for models #422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lee Calcote <[email protected]>
Signed-off-by: Lee Calcote <[email protected]>
Comment on lines
+346
to
+350
| if mf.Annotations == "true" { | ||
| finder = finder.Where("model_dbs.metadata->>'isAnnotation' = true") | ||
| } else if mf.Annotations == "false" { | ||
| finder = finder.Where("model_dbs.metadata->>'isAnnotation' = false") | ||
| } |
There was a problem hiding this comment.
Not sure if that is intentional, if we are making it to accept string we may pass "inlude", "exclude" or one more can't remember, instead of boolean as string -> "true"
There was a problem hiding this comment.
Yes, good point, @Yashsharma1911. I agree that what you've suggested is a desired improvement.
Signed-off-by: MUzairS15 <[email protected]>
MUzairS15
approved these changes
Dec 2, 2023
|
updated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Lee Calcote [email protected]
Description
This PR adds a new
Annotationsproperty to Model FiltersNotes for Reviewers
Signed commits