Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update schema for import #595

Merged
merged 3 commits into from
Sep 27, 2024
Merged

Conversation

Jougan-0
Copy link
Contributor

Description

This PR fixes #

Notes for Reviewers

Signed commits

  • Yes, I signed my commits.

@Jougan-0 Jougan-0 requested a review from MUzairS15 September 27, 2024 10:23
Comment on lines +90 to +104
"Analytics",
"App Definition and Development",
"Cloud Native Network",
"Cloud Native Storage",
"Database",
"Machine Learning",
"Observability and Analysis",
"Orchestration & Management",
"Platform",
"Provisioning",
"Runtime",
"Security & Compliance",
"Serverless",
"Tools",
"Uncategorized"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These should be fetched dynamically, look for the IMport design model (source type field) for reference on dynamically fetching.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MUzairS15 We used enum here to 🤔

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then it must be some other schema, check catalog publish

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll make them dynamically after today's event.

},
"subCategory": {
"type": "string",
"enum": [

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here

@Jougan-0 Jougan-0 merged commit 6fd2108 into meshery:master Sep 27, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants