Fix: Send Possibly Stale Object on Broken WatchConn to Keep Meshery in Sync #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: suod-NithishKarthik <[email protected]>
|
Yay, your first pull request! 👍 A contributor will be by to give feedback soon. In the meantime, please review the Layer5 Community Welcome Guide and sure to join the community Slack. |
Signed-off-by: suod-NithishKarthik <[email protected]>
humblenginr
changed the title
humblenginr
changed the title
humblenginr
changed the title
|
@Utkarsh-pro please review. |
|
@Utkarsh-pro a review would be great.... |
|
Thanks for your contribution to the Layer5 community! 🎉
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, when the informer(reflector component to be specific) performs re-listing because of a broken watch connection, Meshery won't get some delete events because the
objwill be of typeDeletedFinalStateUnknownin those cases.This PR ensures that we don't lose a
Deleteevent when the watch connection established by the informer breaks for some reason, by sending a possibly stale object rather than not sending anything at all.Notes for Reviewers
This may be the reason for #90 and probably related to #100 although I highly doubt that because it is more likely that it's because of the way the clients are handling the events.
Signed commits