Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add golangci-lint's cconfiguration #256

Merged
merged 1 commit into from
Oct 11, 2023
Merged

Add golangci-lint's cconfiguration #256

merged 1 commit into from
Oct 11, 2023

Conversation

Aisuko
Copy link
Member

@Aisuko Aisuko commented Oct 9, 2023

Description

This PR fixes #

Notes for Reviewers

  • Update .golangci.config, make it as same as meshery-operator. It is really useful for check the potential issues of Kubernetes related project. We do not enable all checker or disable all. We should keep the configuration readable by maintainers.
  • This PR also fixed some of issues were checked by golangci-lint of the code.
  • Add code coverage to the CI.

Signed commits

  • Yes, I signed my commits.

@Aisuko Aisuko requested a review from leecalcote October 9, 2023 06:51
@Aisuko Aisuko added area/ci Continuous integration | Build and release area/docs Improvements or additions to documentation area/tests Testing / quality assurance language/go Golang related labels Oct 9, 2023
@Aisuko Aisuko changed the title add golangci-lint's cconfiguration Add golangci-lint's cconfiguration Oct 9, 2023
@Aisuko Aisuko force-pushed the feat/golangci-lint branch 5 times, most recently from 0162347 to 234e71a Compare October 9, 2023 07:36
@codecov
Copy link

codecov bot commented Oct 9, 2023

Welcome to Codecov 🎉

Once merged to your default branch, Codecov will compare your coverage reports and display the results in this comment.

Thanks for integrating Codecov - We've got you covered ☂️

@Aisuko Aisuko force-pushed the feat/golangci-lint branch from 234e71a to c27b197 Compare October 9, 2023 07:43
@Aisuko Aisuko self-assigned this Oct 9, 2023
Copy link
Member Author

@Aisuko Aisuko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved

@Aisuko Aisuko merged commit 882048b into master Oct 11, 2023
6 checks passed
@Aisuko Aisuko deleted the feat/golangci-lint branch October 11, 2023 01:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ci Continuous integration | Build and release area/docs Improvements or additions to documentation area/tests Testing / quality assurance language/go Golang related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant