Use SD card as store&forward memory #5083
Draft
+291
−89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
n.b. this enables store&forward as a client for non-esp32 devices. |
|
@caveman99 The rak board has addon sdcard board also |
|
@markbirss yes, I wanna go slowly step by step. For the rak I thought the flash add-ons would be a better choice. Still looking into this. |
|
Sounds really nice. Any idea on how long a write and read takes (since it seems this isn't asynchronous)? |
Nope, i couldn't test it (yet). It's 200ish byte per file, but also the SDcard interface is usually single lane. |
caveman99
force-pushed
the
store-and-forward
branch
3 times, most recently
from
ea5b17f to
3abe294
Compare
caveman99
force-pushed
the
store-and-forward
branch
from
3abe294 to
7532052
Compare
…mware into store-and-forward
|
Hi |
* First attempt to adding hardware support for NRF52 SPI SD Card using arduino SD library My first time contributing to an open source project so not very confident in what i'm doing. Changes to FSCommon: initializing SD library for NRF52. Progress: No compile error, but SD card does not get initialized properly yet added ifdef ARCH_ESP32 conditions around esp32 SD library functions memget: added ifdef conditional statements StoreForwardModule.cpp: added ifdef conditional statements Rak4631 platfromIO.ini and variant.h: added arduino-libraries/SD@^1.3.0 library to libdeps defined HAS_SDCARD and SPI pins Arduino SD library. Made changes to library because using namespace SDLIB in header file caused ambiguity problems Not sure this is the right way of adding a library, also, how do i implement changes to the library permanently to the project? Am I going somewhat in the right direction with these changes? Tell me your thoughts, thanks * replaced arduino SD library to custom fork. A "using namespace" statement in the header file was to messy to work around. NRF52 SD card initialisation added * updated library reference added card size and type function to SD library added populateSDCard for NRF52 * Changed NRF52 SD object from SDFilesystem to SD Changed NRF52 SD object from SDFilesystem to SD for more compatibility with esp32 SD library. Some functions are still different but most used open, read, write and close are the same. * Removed duplicate ESP32/NRF52 SD card access code Mainly made changes to the custom arduino SD library to make it compatible with the esp32 SD library already used in the store and forward code. With these compatible function names and return, I removed some duplicate code. * trunk fmt and pin SD library to commit hash * print this out on ESP32 anyway --------- Co-authored-by: Thomas Göttgens <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not 100% sure if this is a good idea.