Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove some hasattr checks from Compilers #13736

Merged
merged 3 commits into from
Oct 1, 2024
Merged

Remove some hasattr checks from Compilers #13736

merged 3 commits into from
Oct 1, 2024

Commits on Oct 1, 2024

  1. compilers: annotate lang_suffixes

    @dcbaker
    dcbaker committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    d525027 View commit details
    Browse the repository at this point in the history

  2. compilers: remove hasattr for file_suffixes 

    This is used in exactly two cases, and it's just not worth it. Those two
cases can override the default set of extensions, and in the process
allow a nice bit of code cleanup, especially toward type checking.
    @dcbaker
    dcbaker committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    20baa16 View commit details
    Browse the repository at this point in the history

  3. compilers: remove hasattr from can_compile_suffixes 

    This is never set outside the `Compiler.__init__`, only added to. As
such there's no reason to have this `hasattr` check. It's wasting time
*and* confusing our static checkers.
    @dcbaker
    dcbaker committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    aa312d6 View commit details
    Browse the repository at this point in the history