cargo: Add support for system-deps dependencies
#13778
Conversation
xclaesse
force-pushed
the
cargo-system-deps
branch
from
2ce0fde
to
35226b1
Compare
| feature_overrides: T.Dict[str, T.Dict[str, str]] | ||
|
|
||
| @classmethod | ||
| def from_raw(cls, name: str, raw: T.Any) -> SystemDependency: |
There was a problem hiding this comment.
| def from_raw(cls, name: str, raw: T.Any) -> SystemDependency: | |
| def from_raw(cls, name: str, raw: T.Dict[str, T.Union[str, T.Dict[str, T..Any]]) -> SystemDependency: |
Would still be an improvement, though it would be nicer if we actually annotated this, which would help us with our expectations. But looking at the documentation it's fairly non-trival.
Which, actually, it doesn't look like this handles the case of:
[package.metadata.system-deps]
testlib = "1.2"There was a problem hiding this comment.
I don't see any benefit in using complex typing here, you'll have to cast it for that type anyway... The reality is from_raw is fundamentally untyped because it's what converts a random toml into a typed SystemDependency class. That's why I would like to massively simplify the typing with #12983.
You can't even really know the type at all, metadata field can really be anything.
There was a problem hiding this comment.
I think raw: T.Dict[str, T.Any] is the most you can really tell.
There was a problem hiding this comment.
Fixed the testlib = "1.2" case.
Introduce a global Cargo interpreter state that keeps track of enabled features on each crate. Before generating AST of a Cargo subproject, it downloads every sub-subproject and resolves the set of features enabled on each of them recursively. When it later generates AST for one its dependencies, its set of features and dependencies is already determined.
The library name defaults to its package name, but it can be different. For example: - package name: cairo-sys-rs - library name: cairo-sys - dependency name: ffi
In the case the main project has a .wrap file for a cargo subproject, that subproject's Cargo.lock must be loaded before we can recursively fetch all its dependencies.
xclaesse
force-pushed
the
cargo-system-deps
branch
2 times, most recently
from
962eec5
to
9033de8
Compare
xclaesse
force-pushed
the
cargo-system-deps
branch
from
9033de8
to
4dd5518
Compare
Based on top of #12952