Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fuse: clean up meson build #613

Merged
merged 1 commit into from
Sep 7, 2022
Merged

fuse: clean up meson build #613

merged 1 commit into from
Sep 7, 2022

Conversation

neheb
Copy link
Collaborator

@neheb neheb commented Sep 2, 2022

Signed-off-by: Rosen Penev [email protected]

@eli-schwartz
Copy link
Member

IIRC this was mainly copied from the fuse3 branch as a backport for people stuck with old versions of fuse. Not sure how worth it it is to rewrite that.

I'm especially extremely skeptical of using extremely recent features of Meson such as the new custom dependencies. The main purpose of old versions of fuse is probably for people on old systems with old Meson, and either way this doesn't even declare the minimum required version of Meson.

@neheb
Copy link
Collaborator Author

neheb commented Sep 2, 2022

Makes sense. There are libfuse3 typos in here.

The dependency stuff doesn't seem like a big deal to me. Iconv is not required. Maybe dl is.

edit: I should mention libfuse2 is still used in most places.

git grep +libfuse
net/davfs2/Makefile:  DEPENDS=+libneon +kmod-fuse +libfuse $(ICONV_DEPENDS) $(INTL_DEPENDS)
net/gnunet-fuse/Makefile:  DEPENDS:=gnunet +gnunet-fs +libfuse
utils/afuse/Makefile:  DEPENDS:=+libfuse +fuse-utils
utils/fuse-overlayfs/Makefile:  DEPENDS:=+libfuse3
utils/open-vm-tools/Makefile:  DEPENDS:=+open-vm-tools +libfuse3
utils/owfs/Makefile:  DEPENDS+= +libfuse +fuse-utils
git grep fuse-utils
net/rclone/Makefile:  DEPENDS:=$(GO_ARCH_DEPENDS) +ca-bundle +fuse-utils
git grep fuse3-utils
net/sshfs/Makefile:  DEPENDS:=+fuse3-utils +glib2 +libpthread

Same with NTFS3G

edit: winfsp/cgofuse#50 (comment)

@xclaesse
Copy link
Member

xclaesse commented Sep 2, 2022

Maybe update the wrap to upstream fuse3, those who are stuck with old fuse2 can still use old wraps.

@neheb
Copy link
Collaborator Author

neheb commented Sep 2, 2022

fuse 2 and 3 use different pkgconfig names. I don't see why they should be mutually exclusive.

@xclaesse
Copy link
Member

xclaesse commented Sep 2, 2022

fuse 2 and 3 use different pkgconfig names. I don't see why they should be mutually exclusive.

oh, should be different wraps then, indeed.

@neheb
Copy link
Collaborator Author

neheb commented Sep 3, 2022

@eli-schwartz added fallbacks for older meson versions.

Signed-off-by: Rosen Penev <[email protected]>
@neheb neheb merged commit 1d62399 into mesonbuild:master Sep 7, 2022
@neheb neheb deleted the 2 branch September 7, 2022 00:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants