Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix another regression: a crash introduced in commit feb892f #82

Merged
merged 1 commit into from
Dec 10, 2015
Merged

Fix another regression: a crash introduced in commit feb892f #82

merged 1 commit into from
Dec 10, 2015

Commits on Dec 10, 2015

  1. Fix another regression: a crash introduced in commit feb892f 

    Commit feb892f (from PR mesos#79) introduced a NullPointerException crash:

After the first pass through the `computeResourcesForSlot()` main loop, the
`executorCpuResources` and `executorMemResources` variables are not populated,
and thus incorreclty null, because `subtractedExecutorResources ` was set to
true on the 1st pass.

The fix is to unconditionally set them to the requested resource amounts
unconditionally, and only subtract the resources out of the offer on the
1st pass.

Also an unrelated change:  clarify that the reservations that are being skipped
in a couple functions are *dynamic* reservations.
    @erikdw
    erikdw committed Dec 10, 2015
    Configuration menu
    Copy the full SHA
    f25b16c View commit details
    Browse the repository at this point in the history