-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/store runs in time #210
Conversation
Co-authored-by: Saurabh Mogre <[email protected]> Co-authored-by: Ruge Li <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #210 +/- ##
=======================================
Coverage 98.52% 98.52%
=======================================
Files 16 16
Lines 476 476
=======================================
Hits 469 469
Misses 7 7 ☔ View full report in Codecov by Sentry. |
* set default value of option
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't approve this because I opened the PR, but thanks for the more recent changes Saurabh, they look good to me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#209 has details about a bug while running this in parallel. Other than that, this looks good to go. Very useful update!!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should bring back the check for upload_results
option before merging this.
Just realized I added this in earlier 😅
Thank you for adding this feature and the config checks, looks good to me! #209 seems like a good topic for our next group programming session |
Problem
closes #36
Solution
created a mapping from seed number to results to store all the objects in one simularium file
with @mogres @kvegesna @rugeli
Type of change
Please delete options that are not relevant.
Steps to Verify:
pack -r 'cellpack/examples/recipes/v2/one_sphere.json' -c '/cellpack/cellpack/tests/packing-configs/test_parallel_config.json'