Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/store runs in time #210

Merged
merged 13 commits into from
Nov 3, 2023
Merged

Feature/store runs in time #210

merged 13 commits into from
Nov 3, 2023

Conversation

meganrm
Copy link
Member

@meganrm meganrm commented Oct 27, 2023

Problem

closes #36

Solution

created a mapping from seed number to results to store all the objects in one simularium file
with @mogres @kvegesna @rugeli

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Steps to Verify:

  1. change the parallel setting to false in the config file
  2. pack -r 'cellpack/examples/recipes/v2/one_sphere.json' -c '/cellpack/cellpack/tests/packing-configs/test_parallel_config.json'
  3. should open the _all file in simularium with multiple packings

@codecov-commenter
Copy link

codecov-commenter commented Oct 27, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (37b661a) 98.52% compared to head (1fc790a) 98.52%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #210   +/-   ##
=======================================
  Coverage   98.52%   98.52%           
=======================================
  Files          16       16           
  Lines         476      476           
=======================================
  Hits          469      469           
  Misses          7        7           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions
Copy link

github-actions bot commented Oct 27, 2023

Packing analysis report

Analysis for packing results located at cellpack/tests/outputs/test_spheres/spheresSST

Ingredient name Encapsulating radius Average number packed
ext_A 25 236.0

Packing image

Packing image

Distance analysis

Expected minimum distance: 50.00
Actual minimum distance: 50.01

Ingredient key Pairwise distance distribution
ext_A Distance distribution ext_A

@meganrm meganrm requested review from rugeli and mogres November 1, 2023 21:01
Copy link
Member Author

@meganrm meganrm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't approve this because I opened the PR, but thanks for the more recent changes Saurabh, they look good to me

Copy link
Collaborator

@mogres mogres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#209 has details about a bug while running this in parallel. Other than that, this looks good to go. Very useful update!!

Copy link
Collaborator

@mogres mogres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should bring back the check for upload_results option before merging this.

Just realized I added this in earlier 😅

@rugeli
Copy link
Collaborator

rugeli commented Nov 2, 2023

Thank you for adding this feature and the config checks, looks good to me! #209 seems like a good topic for our next group programming session

@meganrm meganrm merged commit c176ac8 into main Nov 3, 2023
7 checks passed
@meganrm meganrm deleted the feature/store-runs-in-time branch November 3, 2023 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use "time" in simularium files to compare different packing runs
4 participants