Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: deploy ceph BucketClass by default #3034

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

refactor: deploy ceph BucketClass by default #3034

wants to merge 2 commits into from
+53 −50

Conversation

takirala
Copy link
Contributor

What problem does this PR solve?:

  • bumps the cosi-bucket-kit chart version and updates the values structure.
  • deploys BucketClass and BucketAccessClass by default whenever ceph is deployed.

This change will make it easy for UI to list all the available BucketClasses.

Depends on mesosphere/charts#1540

Which issue(s) does this PR fix?:

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Checklist

  • If the PR adds a version bump, ensure there is no breaking change in Licensing model (or NA).
  • If a chart is changed or app configuration is significantly changed, the chart version is correctly incremented (so that apps are not automatically upgraded from a previous version of DKP).

@github-actions github-actions bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. services/rook-ceph-cluster services/kubecost labels Jan 17, 2025
@mesosphere-ci mesosphere-ci added ok-to-test Signals mergebot that CI checks are ready to be kicked off do-not-merge/testing Do not merge because there is still on-going testing open-kommander-pr Automatically triggers the creation of a PR in Kommander repo update-licenses signals mergebot to update licenses.d2iq.yaml labels Jan 17, 2025
@github-actions GitHub Actions
Copy link
Contributor

✅ Created Kommander branch to test kommander-applications changes: https://github.com/mesosphere/kommander/tree/kapps/main/tga/refactor-ceph-cosi

@coveralls
Copy link

coveralls commented Jan 17, 2025 •
edited
Loading

Pull Request Test Coverage Report for Build 12917887739

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 51.703%
Totals Coverage Status
Change from base Build 12917513098: 0.0%
Covered Lines: 167
Relevant Lines: 323
💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
do-not-merge/testing Do not merge because there is still on-going testing ok-to-test Signals mergebot that CI checks are ready to be kicked off open-kommander-pr Automatically triggers the creation of a PR in Kommander repo services/kubecost services/rook-ceph-cluster size/L Denotes a PR that changes 100-499 lines, ignoring generated files. update-licenses signals mergebot to update licenses.d2iq.yaml
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@takirala @coveralls @mesosphere-ci