enhanced the download.sh script for better usability #52
Conversation
|
Hi @rjarun8! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
|
CLA Signed |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
download.sh
Outdated
|
|
||
| # Function to download a file | ||
| download_file() { | ||
| wget -c --quiet --show-progress $1 -O $2 & |
There was a problem hiding this comment.
Should we do quiet? since the downloads could take hours at times, should we allow to show the progress?
There was a problem hiding this comment.
Or actually pass a param would be nice or to keep it simple, possibly just echo the first 100 chars of the url
There was a problem hiding this comment.
thanks for the comments. we are now taking a praram interactively.
There was a problem hiding this comment.
so now the download_file() will operate based on verbosity choice and download_model has been modified to capture this as well
| ALL_MODELS="7b,13b,34b,7b-Python,13b-Python,34b-Python,7b-Instruct,13b-Instruct,34b-Instruct" | ||
| log "${YELLOW}📜 Enter the list of models to download ($ALL_MODELS) example: 7b,13b , or press Enter for all: ${NC}" | ||
| read MODEL_SIZE | ||
| log "Press 'c' to cancel or any other key to continue." |
There was a problem hiding this comment.
We have a log at line 82, do we need this as well?
download.sh
Outdated
|
|
||
| # Function to download a file | ||
| download_file() { | ||
| wget -c --quiet --show-progress $1 -O $2 & |
There was a problem hiding this comment.
Or actually pass a param would be nice or to keep it simple, possibly just echo the first 100 chars of the url
Enhancement on file: download.sh #51