New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support sync for Agent SDK #45

Merged

yanxi0830 merged 9 commits into main from sync_create_turn

Nov 21, 2024

Contributor

yanxi0830 commented Nov 21, 2024 •

edited

Loading

TL;DR

Make create_turn synchrounous & event_logger in Agent SDK wrapper
Make all tool calls sync

Test

Migration done in migration to use sync call agents llama-stack-apps#123

yanxi0830 added 2 commits

November 21, 2024 13:17


          move sync create_turn, event_logger

8f27f7d


          agent lib refactor

a10e8b1

facebook-github-bot added the cla signed label

yanxi0830 added 3 commits

November 21, 2024 13:44


          sync

68f6f59


          simplify

30f7aaa


          simplify

00406b2

yanxi0830 marked this pull request as ready for review

November 21, 2024 21:53


          remove unused

9b170b3

ashwinb requested review from dltn, init27 and heyjustinai

November 21, 2024 22:06

ashwinb reviewed

View reviewed changes

src/llama_stack_client/lib/agents/agent.py Show resolved Hide resolved

ashwinb reviewed

View reviewed changes

src/llama_stack_client/lib/agents/agent.py Outdated Show resolved Hide resolved

ashwinb reviewed

View reviewed changes

src/llama_stack_client/lib/agents/agent.py Show resolved Hide resolved

yanxi0830 added 2 commits

November 21, 2024 14:09


          improve error msg

f61b3b8


          check

a680de1

ashwinb reviewed

View reviewed changes

src/llama_stack_client/lib/agents/event_logger.py Outdated Show resolved Hide resolved

ashwinb reviewed

View reviewed changes

src/llama_stack_client/lib/agents/agent.py Show resolved Hide resolved

yanxi0830 mentioned this pull request

migration to use sync call agents meta-llama/llama-stack-apps#123

Merged

5 tasks


          all sync

72087c4

ashwinb approved these changes

View reviewed changes

Contributor

ashwinb left a comment

looks good!

yanxi0830 merged commit e70d810 into main

3 checks passed

yanxi0830 deleted the sync_create_turn branch

November 21, 2024 22:39

yanxi0830 changed the title ~~Support sync/async for Agent SDK~~ Support sync for Agent SDK

yanxi0830 mentioned this pull request

RAG app example meta-llama/llama-stack-apps#118

Merged

5 tasks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels