Inference to use provider resource id to register and validate #428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dineshyv
requested review from
ashwinb,
yanxi0830,
hardikjshah,
dltn and
raghotham
as code owners
facebook-github-bot
added
the
CLA Signed
yanxi0830
reviewed
Nov 12, 2024
raghotham
reviewed
Nov 12, 2024
dineshyv
force-pushed
the
dineshyv/stackid-to-providerid
branch
from
0f7fcfd
to
948f6ec
Compare
yanxi0830
reviewed
Nov 13, 2024
yanxi0830
reviewed
Nov 13, 2024
yanxi0830
reviewed
Nov 13, 2024
| @@ -237,7 +237,7 @@ async def completion( | |||
| @webmethod(route="/inference/chat_completion") | |||
| async def chat_completion( | |||
| self, | |||
| model: str, | |||
| model_id: str, | |||
There was a problem hiding this comment.
llama-stack-apps examples also needs to be updated: https://github.com/meta-llama/llama-stack-apps/blob/0dc9c42fb42bf21d35e6d231afc4e0360a9eac61/examples/inference/client.py#L46-L49
There was a problem hiding this comment.
There was a problem hiding this comment.
llama-stack-apps and llama-stack-client-python also needs to be updated to reflect the model -> model_id change.
raghotham
approved these changes
Nov 13, 2024
ashwinb
reviewed
Nov 13, 2024
|
very useful change! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the way model id gets translated to the final model name that gets passed through the provider.
Major changes include:
Tested all inference providers including together, fireworks, vllm, ollama, meta reference and bedrock