-
Notifications
You must be signed in to change notification settings - Fork 759
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add persistence for localfs datasets #557
base: main
Are you sure you want to change the base?
Add persistence for localfs datasets #557
Conversation
Hi @VladOS95-cyber! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
111ca21
to
07fca6e
Compare
07fca6e
to
0252898
Compare
Hi @ashwinb @yanxi0830 @hardikjshah @dltn @raghotham! This PR is ready for a review. Please, take a look. |
Hi @VladOS95-cyber thanks for the PR, could you attach the tests you ran in the test plan? |
Hi @yanxi0830! My test results: I don't think that my changes is a root cause of failed one. I found that in |
Hi @yanxi0830! Just a kind reminder, please take a look when you have time, in order to not lose this PR. |
What does this PR do?
Add persistency logic for localfs datasetio provider
Test Plan
Please describe:
Sources
Please link relevant resources if necessary.
#539
Before submitting
Pull Request section?