agents to use tools api #673
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dineshyv
requested review from
ashwinb,
yanxi0830,
hardikjshah,
dltn,
raghotham and
vladimirivic
as code owners
facebook-github-bot
added
the
CLA Signed
ashwinb
reviewed
Dec 21, 2024
| @@ -500,6 +500,8 @@ async def register_tool_group( | |||
| ) | |||
| provider_id = list(self.impls_by_provider_id.keys())[0] | |||
|
|
|||
| # parse tool group to the type if dict | |||
| tool_group = parse_obj_as(ToolGroupDef, tool_group) | |||
There was a problem hiding this comment.
nit: parse_obj_as is deprecated. TypeAdapter(ToolGroupDef).validate_python(...) is the recommended replacement.
ashwinb
reviewed
Dec 21, 2024
| provider_id="brave-search", | ||
| provider_type="inline::brave-search", | ||
| config={ | ||
| "api_key": os.environ["BRAVE_SEARCH_API_KEY"], |
There was a problem hiding this comment.
should this be get_env_or_fail?
There was a problem hiding this comment.
no we skip the test if env is not present
ashwinb
reviewed
Dec 21, 2024
| @@ -55,7 +61,28 @@ def agents_meta_reference() -> ProviderFixture: | |||
| ) | |||
|
|
|||
|
|
|||
| @pytest.fixture(scope="session") | |||
| def tool_runtime_memory() -> ProviderFixture: | |||
There was a problem hiding this comment.
why is this fixture in tests/agents and not in tests/tool_runtime?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Agents to use tools API
Test Plan
pytest -s -v -k fireworks llama_stack/providers/tests/agents/test_agents.py
--safety-shield=meta-llama/Llama-Guard-3-8B
--inference-model=meta-llama/Llama-3.1-8B-Instruct