Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to use importlib instead of deprecated pkg_resources #678

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

terrytangyuan
Copy link
Contributor

pkg_resources has been deprecated. This PR switches to use importlib.resources.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Meta Open Source bot. label Dec 21, 2024
Signed-off-by: Yuan Tang <[email protected]>
Copy link
Contributor

@raghotham raghotham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this change. Are you able to share a gist of the test runs you did to show that there are no regressions in pulling dependencies?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Meta Open Source bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants