-
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update DB setup instructions for importer #49
Conversation
Pipe local SQL files into the container instead of copying them.
Without this migration, loading the page of an (imported) author failed.
I've marked this as draft until I am done with testing the importer UI because I just found another missing migration... This time it was even crashing the server:
As soon as I have tested my schema change to give imports BBIDs and combine the entity and import tables, I should probably abandon the minimal test DB and start using the full DB dump again, they should be much more reliable. |
Should be ready now that metabrainz/bookbrainz-site#1103 and metabrainz/bookbrainz-data-js#319 have been opened. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine.
I will look into automatically generating a minimal test DB at the same time as we generate the regular DB dumps, that way we can have a ready-to-use, always up-to-date minimal DB for testing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ideally we'll get rid of this mess soon and have up to date minimal DBs available somewhere
Just a few documentation changes from my notes to get the importer UI working.