Skip to content

Commit

Permalink
Revert "PICARD-2609: Run metadata comparison on file.update in a thread"
Browse files Browse the repository at this point in the history
This reverts commit 8a3a342.
  • Loading branch information
phw committed Jul 6, 2023
1 parent b41f93e commit eefe7e3
Showing 1 changed file with 0 additions and 11 deletions.
11 changes: 0 additions & 11 deletions picard/file.py
Original file line number Diff line number Diff line change
Expand Up @@ -697,13 +697,6 @@ def _tags_to_update(self, ignored_tags):
yield name

def update(self, signal=True):
thread.run_task(
self._compare_metadata,
partial(self._compare_metadata_finished, signal),
thread_pool=self.tagger.priority_thread_pool
)

def _compare_metadata(self):
if not (self.state == File.ERROR and self.errors):
config = get_config()
clear_existing_tags = config.setting["clear_existing_tags"]
Expand Down Expand Up @@ -731,10 +724,6 @@ def _compare_metadata(self):
self.state = File.CHANGED
else:
self.state = File.NORMAL

def _compare_metadata_finished(self, signal, result=None, error=None):
if error:
log.error("Comparing file metadata for %r failed: %s", self, error)
if signal:
log.debug("Updating file %r", self)
self.update_item()
Expand Down

0 comments on commit eefe7e3

Please sign in to comment.