PICARD-2679: Fix open folder for Snap install #2250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When running as a Snap use xdg-open instead of QDesktopServices. Introduce picard.util.open_local_path helper to wrap this functionality.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Problem
If Picard is installed via Snap all "Open folder" actions do not work. This is for example the case for "Open containing folder" for loaded files, but also for opening the plugin folder or config folder in options.
This is supposed to work via xdg-desktop-portal automatically, and it does work for the Flatpak install. But there seems to be an issue with this on Snap, see https://forum.snapcraft.io/t/xdg-open-or-gvfs-open-qdesktopservices-openurl-file-somelocation-file-txt-wont-open-the-file/16824/14 and https://bugreports.qt.io/browse/QTBUG-83939
Solution
When running as a Snap use xdg-open instead of QDesktopServices. Introduce picard.util.open_local_path helper to wrap this functionality.
Action