Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PICARD-2691: provide signed source archives #2277

Merged
merged 2 commits into from
Aug 14, 2023

Conversation

phw
Copy link
Member

@phw phw commented Aug 14, 2023

Summary

  • This is a…
    • Bug fix
    • Feature addition
    • Refactoring
    • Minor / simple change (like a typo)
    • Other
  • Describe this change in 1-2 sentences:

Problem

Since PyPI stopped providing signed source files we did no longer provide signed sources automatically.

Also we always relied on source files automatically generated by Github for our official release. This causes two source files to exist for Picard (on PyPI and official download). Also the Github generated source files are not stable. They can get regenerated later resulting in changed checksum.

Solution

  • Re-activate GPG source file signing in the PyPI builds
  • Extend the build to generate both tar.gz and zip
  • Make the release-pypi workflow a dependency of the package workflow and publish the resulting artifacts (source archives .tar.gz and .zip + their signatures) on Github release

I did perform a full test deployment cycle on my fork (please ignore the version number mixup and old changelog here, this is still using old number). The workflow run is at https://github.com/phw/picard/actions/runs/5858950764/job/15884133636

See how the picard-sdist artifact contains the .asc signatures.

The deployment result is at https://github.com/phw/picard/releases/tag/release-2.9.1a0 I did a test release, but accidentally already cleaned it up. Anyway, it did successfully deploy the source artifacts to the Github release.

The source files provided there are picard-2.9.tar.gz and picard-2.9.zip, and the corresponding .asc files are also included.

@phw phw requested a review from zas August 14, 2023 18:06
@phw phw merged commit 3b20cb2 into metabrainz:master Aug 14, 2023
63 checks passed
@phw phw deleted the PICARD-2691-provide-signed-sources branch August 14, 2023 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants